Skip to content

[SYCL] Do not decompose arrays with pointers #7015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 13, 2022
Merged

[SYCL] Do not decompose arrays with pointers #7015

merged 6 commits into from
Oct 13, 2022

Conversation

@elizabethandrews
Copy link
Contributor

@elizabethandrews elizabethandrews commented Oct 11, 2022 •
edited
Loading

Arrays with pointers are no longer decomposed into array elements when generating openCL kernel arguments.

Signed-off-by: Elizabeth Andrews elizabeth.andrews@intel.com

@elizabethandrews
[SYCL] Do not decompose arrays with pointers
43c9dd0 
Arrays are no longer decomposed into its elements.

Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
@elizabethandrews elizabethandrews requested a review from a team as a code owner October 11, 2022 03:01
premanandrao
premanandrao reviewed Oct 11, 2022
View reviewed changes
premanandrao
premanandrao reviewed Oct 11, 2022
View reviewed changes
smanna12
smanna12 reviewed Oct 11, 2022
View reviewed changes
smanna12
smanna12 reviewed Oct 11, 2022
View reviewed changes
smanna12
smanna12 reviewed Oct 11, 2022
View reviewed changes
smanna12
smanna12 reviewed Oct 11, 2022
View reviewed changes
smanna12
smanna12 reviewed Oct 11, 2022
View reviewed changes
@elizabethandrews
Apply review comments
2dfe874 
Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
Fznamznon
Fznamznon reviewed Oct 12, 2022
View reviewed changes
@elizabethandrews
Apply review comments
28a35da 
Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
@elizabethandrews
Apply review comment
d60780a 
Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
@pvchupin
Copy link
Contributor

pvchupin commented Oct 13, 2022

@elizabethandrews, please resolve conflicts

@elizabethandrews
Copy link
Contributor Author

elizabethandrews commented Oct 13, 2022 •
edited
Loading

@intel/llvm-gatekeepers PR is ready for review and merge

@pvchupin pvchupin merged commit d4478a4 into intel:sycl Oct 13, 2022
@pvchupin
Copy link
Contributor

pvchupin commented Oct 13, 2022

@elizabethandrews, please follow up on post-commit issues on Windows: https://github.com/intel/llvm/actions/runs/3245312292

Failed Tests (2):
  Clang :: SemaSYCL/array-kernel-param.cpp
  Clang :: SemaSYCL/built-in-type-kernel-arg.cpp

@elizabethandrews elizabethandrews mentioned this pull request Oct 14, 2022
Merged
@elizabethandrews
Copy link
Contributor Author

elizabethandrews commented Oct 14, 2022

@elizabethandrews, please follow up on post-commit issues on Windows: https://github.com/intel/llvm/actions/runs/3245312292

Failed Tests (2):
  Clang :: SemaSYCL/array-kernel-param.cpp
  Clang :: SemaSYCL/built-in-type-kernel-arg.cpp

#7064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fznamznon Fznamznon Fznamznon approved these changes

@premanandrao premanandrao premanandrao approved these changes

+1 more reviewer

@smanna12 smanna12 smanna12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@elizabethandrews @pvchupin @Fznamznon @premanandrao @smanna12